Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): Update non-ASCII art text #1140

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

kesara
Copy link
Member

@kesara kesara commented Jul 10, 2024

Fixes #617

This change introduces two new command line options for text:

       --rfc-html-archive-url
          Default value: https://www.rfc-editor.org/rfc/
          URL for HTML file archive of RFCs.

       --id-html-archive-url
          Default value: https://www.ietf.org/archive/id/
          URL for HTML file archive Internet-Drafts.
Update text outputs:

For I-Ds:

(Artwork only available as svg: see https://www.ietf.org/archive/id/<docname>.html)

For RFCs:

(Artwork only available as svg: see https://www.rfc-editor.org/rfc/rfc<rfc number>.html)

@cabo
Copy link
Contributor

cabo commented Jul 10, 2024

Is it possible to link to the actual figure?

@kesara
Copy link
Member Author

kesara commented Jul 10, 2024

@cabo figure for artwork is optional. HTML processor adds anchors when there is no figure for artwork. HTML processing and text processing are two separate processors.
It is hard to guess the HTML anchors by text processor accurately.

Fixes ietf-tools#617

This change introduces two new command line options for text:
   --rfc-html-archive-url
      Default value: https://www.rfc-editor.org/rfc/
      URL for HTML file archive of RFCs.

   --id-html-archive-url
      Default value: https://www.ietf.org/archive/id/
      URL for HTML file archive Internet-Drafts.
@kesara kesara merged commit 3b5cb99 into ietf-tools:main Sep 16, 2024
13 checks passed
@kesara kesara deleted the fix/svg-only branch September 16, 2024 22:19
kesara added a commit that referenced this pull request Sep 16, 2024
* fix(text): Update non-ASCII art text

Fixes #617

This change introduces two new command line options for text:
   --rfc-html-archive-url
      Default value: https://www.rfc-editor.org/rfc/
      URL for HTML file archive of RFCs.

   --id-html-archive-url
      Default value: https://www.ietf.org/archive/id/
      URL for HTML file archive Internet-Drafts.

* chore: Run yestests pre-changes

* chore: Run yestests post-changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use rfc filename in text output when only svg is provided
3 participants